-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honour local claim dialect. #38
Honour local claim dialect. #38
Conversation
PR builder started |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
============================================
+ Coverage 27.12% 30.87% +3.74%
- Complexity 135 149 +14
============================================
Files 8 8
Lines 2997 2999 +2
Branches 855 858 +3
============================================
+ Hits 813 926 +113
+ Misses 2019 1901 -118
- Partials 165 172 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7f21b40
to
d635234
Compare
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13229016526
...ailotp/src/main/java/org/wso2/carbon/identity/local/auth/emailotp/EmailOTPAuthenticator.java
Outdated
Show resolved
Hide resolved
d635234
to
8be4bf2
Compare
8be4bf2
to
f7c98f8
Compare
PR builder started |
PR builder started |
PR builder completed |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13232470295
Issue:
This PR fixes an issue where email resolution for sending an email OTP does not honor the local claim dialect.
If the authenticator's claim dialect is not the OIDC dialect, it directly checks for claim mapping. However, IdPs using the local claim dialect do not have claim mappings, causing the issue.
This fix ensures that if idp.isLocalClaimDialect() returns true, the email is retrieved using the WSO2 email claim.