Feature/settings new design #3479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edbrett
suggested changes
Jun 14, 2018
|
|
||
| &:last-child { | ||
| border: 0; | ||
| margin-bottom: 0; |
| @@ -1,54 +1,67 @@ | |||
| @import '~styles/settings.scss'; | |||
|
|
|||
| .c-widget-settings { | |||
| width: rem(250px); | |||
| width: rem(310px); | |||
There was a problem hiding this comment.
Can we make this 290px? As for iphone 5 screen width is 320px and we have a standard padding of rem(15px) each side?
| } | ||
| } | ||
|
|
||
| .canopy-select { | ||
| display: flex; |
|
Also, I just remembered that the design for the locations selector has changed since this was made. There should be a border between the landCategroy selector and the rest. Like we have here: |
|
@edbrett I think all the cases are covered now! Thx for your review 🙇 |
edbrett
approved these changes
Jun 15, 2018
edbrett
added
do_not_merge
staging
|
They love it! Great work duuuuude 🌟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview