Feature/decide update or reload #3368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edbrett
suggested changes
Apr 20, 2018
| @@ -52,6 +52,13 @@ class Loss extends Canvas { | |||
| .replace('{z}', z) | |||
| .replace('{threshold}', this.options.threshold); | |||
| } | |||
|
|
|||
| setOptions(options) { | |||
There was a problem hiding this comment.
Can this go on the parent layer?
There was a problem hiding this comment.
We have this method on the parent layer.
This is only an overwrite, for an specific behaviour for this layer.
There was a problem hiding this comment.
But it is repeated 3 times in loss, cover, and glads. When it could go in the parent canvas.js and still work fine?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We have dynamic update in the canvas layers, but when we need to change the threshold, it affects the url, so in this case we need to reload the layer.
