Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/modal-meta-dependency #3334

Merged
merged 1 commit into from
Mar 12, 2018
Merged

fix/modal-meta-dependency #3334

merged 1 commit into from
Mar 12, 2018

Conversation

pjosh
Copy link
Contributor

@pjosh pjosh commented Mar 12, 2018

Overview

If you use the <Dropdown> component without the <ModalMeta> component, the page breaks.

@pjosh pjosh requested a review from edbrett March 12, 2018 11:08
edbrett
edbrett approved these changes Mar 12, 2018
View reviewed changes
Copy link
Contributor

@edbrett edbrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@edbrett edbrett merged commit 03d342b into develop Mar 12, 2018
@edbrett edbrett deleted the fix/modal-meta-dependency branch March 12, 2018 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edbrett edbrett edbrett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjosh @edbrett