Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gee recent imagery #3331

Merged
merged 181 commits into from
May 9, 2018
Merged

Feature/gee recent imagery #3331

merged 181 commits into from
May 9, 2018

Conversation

pjosh
Copy link
Contributor

@pjosh pjosh commented Mar 6, 2018

No description provided.

@pjosh pjosh added the WIP Any PR that should not be merged to develop label Mar 6, 2018
@pjosh pjosh temporarily deployed to gfw-nav April 30, 2018 20:30 Inactive
@edbrett edbrett removed the WIP Any PR that should not be merged to develop label May 9, 2018
Copy link
Contributor

@edbrett edbrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing feature, amazing work 🎉 👏 😎 🆒 . Many thanks to all who have contributed!! @pjosh @benlaken @01painadam.

mps.publish('Layer/update', [name]);
},

setSentinel: function(value) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to recent imagery for consitency

this.publishSentinel();
},

publishSentinel: function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

'map/services/DataService'
], function(Class, UriTemplate, Promise, ds) {

/* eslint-disable */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After review, delete this file. It has no friends.

SentinelService,
Presenter
) {
/* eslint-disable */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change name to recent imagery tile layer etc

import { DragSource } from 'react-dnd';

const dragSource = {
beginDrag(props) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VERY 🆒

getRecentTiles(params)
.then(response => {
if (response.data.data.length) {
const data = response.data.data[0].attributes;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets find a way to manage errors and failed fetches in the react to map bridge. Maybe a notification component (same as current styles) for top of map.

@edbrett edbrett merged commit b6c0860 into develop May 9, 2018
@edbrett edbrett deleted the feature/GEE-recent-imagery branch May 9, 2018 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging Any PR expected to be kept on staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants