Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes getLocationsLoss query #3330

Merged
merged 1 commit into from
Mar 5, 2018
Merged

Fixes getLocationsLoss query #3330

merged 1 commit into from
Mar 5, 2018

Conversation

01painadam
Copy link
Contributor

@01painadam 01painadam commented Mar 5, 2018

Overview

There was an issue in that the 'Where is Forest Loss Located?' was reporting larger loss in adm2 regions than was found in the entire adm1 supra-region!

This was due to a small bug in the way the aggregated loss query was formed, which had now been fixed!

Testing

As always, please test!

  • Check the values here
  • Check that they match for the total reported in each adm2 region here
  • Are they consistent (e.g.947kha =/= 120kha in this case... but should be fixed in local)

Copy link
Contributor

@edbrett edbrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixy McFixFix 👏 👍 🐞 🔨

@edbrett edbrett merged commit 0a494c7 into develop Mar 5, 2018
@edbrett edbrett deleted the bugfix/loss-query branch March 7, 2018 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants