Fix/resizing of country page #3328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j8seangel
approved these changes
Mar 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We had some issues when resizing the country page on mobile devices, and also the sticky map not displaying on render. This PR updates the layout and CSS of the country's root component to fix these issues and make the page better as a whole. I have also removed the custom sticky implementation in exchange for react-stckynode from Yahoo.
BONUS: updated to fix the height of the map to the full screen to prevent hiding the legend, with the zoom controls sticky when scrolling with the map.
NOTE: there is a bug in recharts that if affect resizing from big to small. We have set the responsive container to use 99% width to handle this but sometimes the resizing is slow.