Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/country widget fixes #3324

Merged
merged 8 commits into from
Feb 28, 2018
Merged

Fix/country widget fixes #3324

merged 8 commits into from
Feb 28, 2018

Conversation

edbrett
Copy link
Contributor

@edbrett edbrett commented Feb 27, 2018

Overview

Bug fixes and improvements for country pages:

  • Only show large 'show map' buttons when on multi column view
  • Disable map button cursor when on map
  • Fix the height of the glads widget sentence to prevent graph movement
  • Fix the padding on the fires widget x axis
  • Show loader on render for fires widget (was waiting for Geostore and showing 'no data')
  • Fix modal hiding the tooltip when closing for widget meta data
  • Send correct meta data key for DRC and COD primary forests selector option

@edbrett edbrett requested a review from pjosh February 27, 2018 18:08
pjosh
pjosh approved these changes Feb 28, 2018
View reviewed changes
Copy link
Contributor

@pjosh pjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works good! good job 👏

@edbrett edbrett merged commit 896b234 into develop Feb 28, 2018
@edbrett edbrett deleted the fix/country-widget-fixes branch February 28, 2018 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjosh pjosh pjosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edbrett @pjosh