Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hydro bugfix: correctly handle lake_option=3 / no DA case, WRF-Hydro PR#808 #2182

Conversation

scrasmussen
Copy link
Contributor

@scrasmussen scrasmussen commented Mar 12, 2025

TYPE: bugfix

KEYWORDS: hydro, bugfix, lake_option, reservoir DA

SOURCE: Soren Rasmussen, internal hydro group

DESCRIPTION OF CHANGES:
Problem: If lake_option was set to 3 (Reservoir DA) but no Reservoir DA flags were set to .true. the internal lake_option was not set to [levelpool/off/passthrough] and a cryptic error resulted.

Solution: NCAR/wrf_hydro_nwm_public#808 This fix now prints an error message and reverts the value to Level Pool if no DA option is selected.

LIST OF MODIFIED FILES:

M       hydro/OrchestratorLayer/config.F90

TESTS CONDUCTED:

  1. Do mods fix problem? Yes, tested in the WRF-Hydro model. WRF builds with GNU
  2. Are the Jenkins tests all passing? Yes

RELEASE NOTE: Hydro reservoir drainage area (DA) lake option bugfix

@scrasmussen scrasmussen requested a review from a team as a code owner March 12, 2025 19:13
@scrasmussen
Copy link
Contributor Author

Jenkins Results:

Please find result of the WRF regression test cases in the attachment. This build is for Commit ID: 11b4c4c, requested by: scrasmussen for PR: https://github.com/scala-computing/WRF/pull/2182. For any query please send e-mail to Wei Wang.

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@islas islas merged commit 313834d into wrf-model:release-v4.7.0 Apr 1, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants