Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #57

Merged
merged 8 commits into from
Aug 16, 2024
Merged

Update dependencies #57

merged 8 commits into from
Aug 16, 2024

Conversation

Nabushika
Copy link
Contributor

@Nabushika Nabushika commented Aug 14, 2024

Update all dependencies, including hyper to 1.4 and using thiserror instead of error-chain
Fix broken test
Make clippy happy

Closes #48
Closes #19

@Nabushika
Copy link
Contributor Author

Tested this locally, all seems to be working!!

@sgrimee
Copy link
Contributor

sgrimee commented Aug 15, 2024

when fixing the test (thanks!) would it be possible to also adjust the comment so that it is consistent with the logic?
It says: "// invalid UUID (assumed base64) should return the event id"
It should say: "// invalid UUID (assumed base64) should return itself unmodified". Because it is not clear that it is the same as the event ID.

@aknarts aknarts merged commit 70c9b57 into wr-org:master Aug 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to hyper 1 Use thiserror instead of error-chain
3 participants