Add high level way of getting systemserver nt instance #7683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: ntcore
PeterJohnson
previously approved these changes
Jan 14, 2025
| extern "C" { | ||
|
|
||
| NT_Inst HAL_GetSystemServerHandle(void) { | ||
| return 0; |
There was a problem hiding this comment.
This is actually an interesting future conversation... but yes, makes sense for now.
There was a problem hiding this comment.
Yes, we do need to have that conversation at some point. But for now we just need something working slightly better.
The main reason I'm adding this is I'm probably going to put the IMU code at the high level, purely because I don't want to make the HAL depend on wpimath, and the IMU gives values in a Quaternion.
PeterJohnson
previously approved these changes
Jan 15, 2025
PeterJohnson
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way its accessible from user programs without creating another instance.