Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wpimath] remove WheelPositions interface/concept #6771

Merged
merged 3 commits into from
Jul 16, 2024
Merged

[wpimath] remove WheelPositions interface/concept #6771

merged 3 commits into from
Jul 16, 2024

Conversation

Alextopher
Copy link
Contributor

@Alextopher Alextopher commented Jun 23, 2024 •
edited
Loading

Closes #6706

@Alextopher Alextopher requested a review from a team as a code owner June 23, 2024 21:26
@KangarooKoala
Copy link
Contributor

You'll need to run Java formatting locally (./gradlew wpimath:spotlessApply), but otherwise looks good to me, for what it's worth.

@Gold856
Copy link
Contributor

Gold856 commented Jun 23, 2024

Should this PR also remove/deprecate the copy methods left over from the WheelPositions interface on all the WheelPositions classes?

@spacey-sooty
Copy link
Contributor

Should this PR also remove/deprecate the copy methods left over from the WheelPositions interface on all the WheelPositions classes?

imo yes

@PeterJohnson PeterJohnson requested a review from calcmogul July 16, 2024 00:21
@PeterJohnson PeterJohnson merged commit 6c0429c into wpilibsuite:main Jul 16, 2024
31 of 32 checks passed
calcmogul added a commit to calcmogul/allwpilib that referenced this pull request Jul 16, 2024
@calcmogul
[wpimath] Fix build by removing a bad #include
d551723 
WheelPositions.h was removed in wpilibsuite#6771.
@calcmogul calcmogul mentioned this pull request Jul 16, 2024
Merged
PeterJohnson pushed a commit that referenced this pull request Jul 16, 2024
@calcmogul
[wpimath] Fix build by removing a bad #include (#6843)
8f60dc7 
WheelPositions.h was removed in #6771.
This was referenced Jan 3, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calcmogul calcmogul calcmogul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[wpimath] Remove or deprecate unused WheelPositions interface/concept
6 participants
@Alextopher @KangarooKoala @Gold856 @spacey-sooty @calcmogul @PeterJohnson