Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wpiunits] Fix measure isNear function #6313

Merged

Conversation

vichik123
Copy link
Contributor

Now the function allows comparison between negative numbers, positive numbers or one and the other.
I also added tests to make sure this feature works.

Now the function allows comparison between negative numbers, positive numbers or both.
@vichik123 vichik123 requested a review from a team as a code owner January 26, 2024 08:52
@vichik123 vichik123 changed the title [wpiunits] Fix measure is near function [wpiunits] Fix measure isNear function Jan 26, 2024
Copy link
Member

@SamCarlberg SamCarlberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@PeterJohnson PeterJohnson merged commit 90bb6cf into wpilibsuite:main Jan 31, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants