-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sysid] Show warning tooltips next to bad feedforward gains instead of throwing #6251
[sysid] Show warning tooltips next to bad feedforward gains instead of throwing #6251
Conversation
Looks like its mad about how I initialize some structs. I thought that maybe I could just leave the arguments I didn't need out to let them be default initialized, but it doesn't seem like its happy about that. Maybe that's only a thing in C++23? (is wpilib on C++11?) |
WPILib uses C++20. You're probably looking for form (3) or (4) on https://en.cppreference.com/w/cpp/language/aggregate_initialization. |
Is the way im initializing structs with partially left out values to be "default" initialized only a thing in a newer version? My local setup must be also on an incorrect version then, since both intellisense and local builds are happy. |
The syntax you wrote isn't a thing on any version. You have to write it like this instead: thing = {.field = newValue}; |
Huh. I wonder why it still works 🤔. I'll make sure to address it on the next commit, though. |
I think this should be unrelated to my changes - is this a flaky test? |
Yes. Ignore it. |
Refactors SysId error handling to not completely cancel analysis when bad feedforward gains are encountered but instead show a warning next to the specific gains that are invalid (with reasoning) - closes #6198.
Also still needs to address #6248.#6248 should instead be addressed in a separate PR.