Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate footgun method of timer #2322

Merged
merged 2 commits into from
Feb 8, 2020
Merged

deprecate footgun method of timer #2322

merged 2 commits into from
Feb 8, 2020

Conversation

Oblarg
Copy link
Contributor

@Oblarg Oblarg commented Jan 31, 2020

Fixes #2321

@Oblarg Oblarg force-pushed the fix_hasperiodpassed branch from dda23dd to 84b9b92 Compare January 31, 2020 21:12
@sciencewhiz
Copy link
Contributor

I don't think we should deprecate existing methods mid-season. Adding better methods and pointing to them is what we should do.

@Oblarg
Copy link
Contributor Author

Oblarg commented Feb 3, 2020

I'll remove the deprecation notices, then.

@PeterJohnson PeterJohnson merged commit f0a18f3 into wpilibsuite:master Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterJohnson PeterJohnson PeterJohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timer.hasPeriodPassed() is a major footgun
3 participants
@Oblarg @sciencewhiz @PeterJohnson