Fix static colors having zero values & add test #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should the test use the equals from the Color class? |
|
It could but if there would be another bug in how Colors are constructed it wouldn't catch it. |
|
Maybe another test of equals. Because of the rounding, I'm not sure that the equals will work. |
|
I can add another test |
|
Huh, was really confused because of what happend while testing. |
PeterJohnson
approved these changes
Jan 13, 2020
pjbuterbaugh
pushed a commit
to pjbuterbaugh/allwpilib
that referenced
this pull request
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Colors were being initialized before
kPrecisionwas 😢