-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add callback handlers for LiveWindow #2053
Conversation
Fixes #2223 |
I tested with an java old command project and made a command that sets a speed controller to a random number in execute. I added a call to the scheduler run in testPeriodic. With 2020.1.2, when I went to test mode, the command continued to execute. With this PR, the command stopped executing when going to test mode as expected. More testing with new commands and C++ to come |
The New Command template calls |
Tested New Command with Java and didn't have any problems. |
Tested old command with C++ without issues |
@Oblarg any heartburn about removing the cancelAll in the template if it's being done behind the scenes with this PR? |
I think it's slightly better to do it explicitly but I don't feel super strongly about it. |
Tested new command with C++ without issues |
No description provided.