Look for theme.json
files in the styles
directory of a theme
#311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #306
It adds supports for looking for translatable strings in JSON files within the
styles
directory of a theme. Unlike the top-leveltheme.json
file we don't lock any names in this case: any JSON file within thestyles
folder is a candidate we should consider.How to test
Automated tests:
composer behat -- features/makepot.feature
Manual test:
composer install
foo-theme
that contains astyles
directory.styles
directory create amy-style.json
file with the following contents:vendor/bin/wp i18n make-pot foo-theme
foo-theme/foo-theme.pot
file and that the "My color" string is present as well as its context "Color name". You should see something like: