Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix content loss in Group block #1209

Merged
merged 4 commits into from
Jul 9, 2019

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Jul 9, 2019

Fixes #1206

Gutenberg side PR: WordPress/gutenberg#14443

To test:

  • Boot the demo app with the following value in initial-html.js
<!-- wp:group -->
<div class="wp-block-group"><div class="wp-block-group__inner-container">
<!-- wp:paragraph -->
<p>hello world</p>
<!-- /wp:paragraph -->
</div></div>
<!-- /wp:group -->

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@Tug Tug added the bugfix label Jul 9, 2019
@Tug Tug added this to the 1.9 milestone Jul 9, 2019
@Tug Tug requested a review from hypest July 9, 2019 10:37
@Tug Tug self-assigned this Jul 9, 2019
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Small note, main WP apps cannot be used directly against this PR since there are some bridge changes (merged in a different PR) that haven't yet been adapted. I manually made the adaptation and verified this PR works OK!

Also, good job helping out on the Gutenberg side PR that @mcsf started!

Feel free to update this PR and merge when the Gutenberg side PR gets merged 👍

@Tug Tug merged commit 44e263c into develop Jul 9, 2019
@Tug Tug deleted the try/fix-parser-reserialize-unknown-blocks branch July 9, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content loss in Group block
2 participants