Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notification settings issues and add settings to Site Details #24134

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from
Open

Fix notification settings issues and add settings to Site Details #24134

wants to merge 6 commits into from

Conversation

kean
Copy link
Contributor

@kean kean commented Feb 28, 2025 •
edited
Loading

Changes

  • Add "Notification Settings" bell to the "Site Details" screen to match the web – it's the primary place where it should've always been
  • Fix an issue where the "Notifications Settings" bell for site subscriptions was not updated after the changes (RCA: you need to observe managed object relationships)
  • Update the logic behind the bell. It now show the "bell with waves" when push notifications are enabled. The default state when you subscribed to a new site is "pushes disabled", so it's an important indicator.

Note: I'm not a huge fan of the design on this page, but changing it wasn't in the scope.

Screenshot 2025-02-28 at 3 48 40 PM
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-28.at.15.48.30.mp4

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the Reader label Feb 28, 2025
@kean kean added this to the 25.8 milestone Feb 28, 2025
@kean kean requested a review from crazytonyli February 28, 2025 20:51
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 25.8. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

kean
kean commented Feb 28, 2025
View reviewed changes
WordPress/Classes/ViewRelated/Reader/Controllers/ReaderStreamViewController+Sharing.swift
@@ -15,7 +15,7 @@ extension ReaderStreamViewController {
removeShareButton()
return
}
let button = UIBarButtonItem(title: nil, image: UIImage(systemName: "square.and.arrow.up"), target: self, action: #selector(shareButtonTapped))
let button = UIBarButtonItem(title: nil, image: UIImage(named: "wpl-share"), target: self, action: #selector(shareButtonTapped))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor last-minute change to adopt new WordPress icons.

...asses/ViewRelated/Notifications/Controllers/NotificationSiteSubscriptionViewController.swift
@@ -132,6 +132,9 @@ class NotificationSiteSubscriptionViewController: UITableViewController {
// Hide the separators, whenever the table is empty
tableView.tableFooterView = UIView()

tableView.tableHeaderView = UIView(frame: CGRect(x: 0.0, y: 0.0, width: 0.0, height: 8))
tableView.sectionHeaderHeight = 12
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made it fit in the .medium() sheet detent.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24134-0d7b284
Version25.7.1
Bundle IDorg.wordpress.alpha
Commit0d7b284
App Center BuildWPiOS - One-Offs #11570
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24134-0d7b284
Version25.7.1
Bundle IDcom.jetpack.alpha
Commit0d7b284
App Center Buildjetpack-installable-builds #10601
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean enabled auto-merge February 28, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazytonyli crazytonyli Awaiting requested review from crazytonyli

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Reader
Projects
None yet
Milestone
25.8
Development

Successfully merging this pull request may close these issues.
3 participants
@kean @dangermattic @wpmobilebot