-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Aztec to use new media pickers (requires Xcode 15) #22060
Conversation
fe2145c
to
8a8e7d2
Compare
FYI, @twstokes. |
fcdbc79
to
7b140bb
Compare
Hey, @mokagio. What's the timeline for switching to Xcode 15? This PR requires iOS 17 SDK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described! 1 small thing - I'm not sure if this is an iOS 17 issue, or a simulator issue, but when I launch the Aztec editor the toolbar is partially obscured. I think normally this shouldn't be a problem because the keyboard will be displayed underneath the toolbar, but thought it may be worth mentioning

This is awesome. Thank you! |
Squashed commits: [0989edb] Remove deprecated code
7b140bb
to
1099db6
Compare
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr22060-dc03e76 | |
Version | 23.7 | |
Bundle ID | org.wordpress.alpha | |
Commit | dc03e76 | |
App Center Build | WPiOS - One-Offs #7964 |
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr22060-dc03e76 | |
Version | 23.7 | |
Bundle ID | com.jetpack.alpha | |
Commit | dc03e76 | |
App Center Build | jetpack-installable-builds #6988 |
This is one of the remaining prerequisites for fully decommissioning WPMediaPicker.
Note: this PR requires Xcode 15; please test it locally.
Changes
SiteMediaPickerViewController
for selection from your site mediaPHPickerViewController
for selection from PhotosUIImagePickerController
for camera capturePHPickerViewController
to replace the embedded picker. It’s available only on iOS 17, which I think is an acceptable trade-off, considering the extremely low number of Aztec users and people who use this option. The iOS 17 adoption has been lagging behind, but by the time this release I expect at least 50% of users to be on iOS 17. I considered implementing a custom picker using Photos.framework andPHAsset
, but since the app no longer asks for Photos permissions anywhere else, I don't think it's viable. It also would've required full access to Photos (not "Only Selected")To test:
Prerequisite: In
EditorFactory.swift
, updateEditorFactory
instantiateEditor` to always return Aztec.Embedded picker
Inserting Media
Keyboard Toolbar
iOS 16 and Earlier
Camera
Photos
PHPickerViewController
Site Media
PHPickerViewController
Regression Notes
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: