-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock Screen Widgets: This Week Chart Widget #21514
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr21514-477d1bc | |
Version | 24.0 | |
Bundle ID | org.wordpress.alpha | |
Commit | 477d1bc | |
App Center Build | WPiOS - One-Offs #8358 |
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr21514-acbdbda | |
Version | 23.7 | |
Bundle ID | com.jetpack.alpha | |
Commit | acbdbda | |
App Center Build | jetpack-installable-builds #7154 |
4 tasks
…ite-creation-pass-domain-name-back-from-calypso Plans in Site Creation: Use domain_name returned from Plan Selection view
- Use Swift Charts - Shows 14-column bar chart - If not enough data shows single field view
99c877f
to
535d3e6
Compare
13 tasks
@guarani, it was a lower-priority task but it is ready for review now. If you had time to review before the end of next sprint that would be great. Thank you! 🙇 |
61d4abb
to
cc23825
Compare
@guarani I have it merged with the latest trunk and no other widget PRs is blocking it now. We could try getting it into 23.8 or 23.9. |
This is necessary to get up to date with a CI configuration change that requires running on Xcode 15.1. See #22270
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21501
LockScreenWidgetChartView
which shows a bar chartRelevant discussion: pc8eDl-14z-p2#comment-935
To test:
Regression Notes
Shouldn't affect other widgets
None
None
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: