Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock Screen Widgets: This Week Chart Widget #21514

Closed
wants to merge 9 commits into from

Conversation

staskus
Copy link
Contributor

@staskus staskus commented Sep 7, 2023

Fixes #21501

  • Created LockScreenWidgetChartView which shows a bar chart
  • Created Providers and Configs
image

Relevant discussion: pc8eDl-14z-p2#comment-935

To test:

  1. Open Jetpack
  2. Log into account
  3. Go to lock screen, long press, customize, tap on widget area, select Jetpack app
  4. Confirm "This Week Views" widget exists
  5. Confirm it shows a single field widget for a site with no views data
  6. Confirm it shows a 7-day line-area chart and it correctly corresponds to days
  7. Confirm a total is shown correctly

Regression Notes

  1. Potential unintended areas of impact

Shouldn't affect other widgets

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

None

  1. What automated tests I added (or what prevented me from doing so)

None

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 7, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21514-477d1bc
Version24.0
Bundle IDorg.wordpress.alpha
Commit477d1bc
App Center BuildWPiOS - One-Offs #8358
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 7, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21514-acbdbda
Version23.7
Bundle IDcom.jetpack.alpha
Commitacbdbda
App Center Buildjetpack-installable-builds #7154
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@staskus staskus mentioned this pull request Sep 8, 2023
4 tasks
…ite-creation-pass-domain-name-back-from-calypso

Plans in Site Creation: Use domain_name returned from Plan Selection view
- Use Swift Charts
- Shows 14-column bar chart
- If not enough data shows single field view
@staskus staskus force-pushed the task/21501-this-week-chart-widget branch from 99c877f to 535d3e6 Compare October 19, 2023 14:49
@staskus staskus marked this pull request as ready for review October 25, 2023 07:38
@staskus staskus added this to the Pending milestone Oct 27, 2023
@staskus staskus requested a review from guarani October 27, 2023 10:47
@staskus
Copy link
Contributor Author

staskus commented Oct 27, 2023

@guarani, it was a lower-priority task but it is ready for review now. If you had time to review before the end of next sprint that would be great. Thank you! 🙇

@staskus staskus force-pushed the task/21501-this-week-chart-widget branch from 61d4abb to cc23825 Compare November 23, 2023 13:15
@staskus
Copy link
Contributor Author

staskus commented Nov 24, 2023

@guarani I have it merged with the latest trunk and no other widget PRs is blocking it now. We could try getting it into 23.8 or 23.9.

This is necessary to get up to date with a CI configuration change that
requires running on Xcode 15.1.

See #22270
@staskus staskus closed this Jun 17, 2024
@jkmassel jkmassel deleted the task/21501-this-week-chart-widget branch July 26, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lock Screen Widgets: Create Chart Widget for This Week configuration
3 participants