Update Gifu to 3.3.1 #21161
Merged
Update Gifu to 3.3.1 #21161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kean
commented
Jul 21, 2023
| @@ -221,9 +221,9 @@ public class CachedAnimatedImageView: UIImageView, GIFAnimatable { | |||
| animatedGifData = data | |||
| DispatchQueue.main.async() { | |||
| self.setFrameBufferCount(self.gifPlaybackStrategy.frameBufferCount) | |||
| self.animate(withGIFData: data) { | |||
There was a problem hiding this comment.
If fixes the this new-ish warning: https://github.com/apple/swift-evolution/blob/main/proposals/0286-forward-scan-trailing-closures.md
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21161-d4c4c29 | |
| Version | 22.8 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | d4c4c29 | |
| App Center Build | WPiOS - One-Offs #6477 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21161-d4c4c29 | |
| Version | 22.8 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | d4c4c29 | |
| App Center Build | jetpack-installable-builds #5508 |
staskus
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
Fortunately, I fixed this crash in Gifu two years ago 😃
Okay 😅
Power of open source integrating your own changes from 2 years ago 👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21160
Fortunately, I fixed this crash in Gifu two years ago 😃
To test:
The crash is a race condition and you have to be very unlucky to reproduce it.
Regression Notes
PR submission checklist:
RELEASE-NOTES.txtif necessary.