Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate gutenberg-mobile release 1.86.1 #19814

Merged
merged 3 commits into from
Dec 27, 2022
Merged

Integrate gutenberg-mobile release 1.86.1 #19814

merged 3 commits into from
Dec 27, 2022

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Dec 27, 2022 •
edited
Loading

Description

This PR incorporates the 1.86.1 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#5350

Release Submission Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux added the Gutenberg Editing and display of Gutenberg blocks. label Dec 27, 2022
@geriux geriux added this to the 21.4 ❄️ milestone Dec 27, 2022
wpmobilebot
wpmobilebot reviewed Dec 27, 2022
View reviewed changes
Podfile Outdated
@@ -91,7 +91,7 @@ def shared_style_pods
end

def gutenberg_pods
gutenberg tag: 'v1.86.0'
gutenberg :commit => '472550a84da5c634a452094733278581dd678737'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Use the new Ruby 1.9 hash syntax.

@geriux geriux mentioned this pull request Dec 27, 2022
Merged
4 tasks
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 27, 2022 •
edited
Loading

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19814-ea2b63e on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 27, 2022 •
edited
Loading

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19814-ea2b63e on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@geriux geriux requested a review from fluiddot December 27, 2022 11:36
@geriux geriux marked this pull request as ready for review December 27, 2022 11:36
fluiddot
fluiddot approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 . Approved via wordpress-mobile/gutenberg-mobile#5350.

@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@geriux geriux merged commit e784794 into release/21.4 Dec 27, 2022
@geriux geriux deleted the gutenberg/integrate_release_1.86.1 branch December 27, 2022 15:43
@spencertransier spencertransier mentioned this pull request Dec 31, 2022
Merged
@spencertransier
Copy link
Contributor

This fix made it into the 21.4.0.1 build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpmobilebot wpmobilebot wpmobilebot left review comments

@fluiddot fluiddot fluiddot approved these changes

Assignees
No one assigned
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
21.4
Development

Successfully merging this pull request may close these issues.
4 participants
@geriux @wpmobilebot @spencertransier @fluiddot