Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For testing image size setting, click to cycle though available sizes. #13052

Closed

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Dec 6, 2019

Fixes gb-mobile 1452

Description

This PR is for testing a simple approach to updating Image Sizes from the Image Block Settings menu by cycling through available values when the size row is pressed.

size-changes

To test:

  1. Navigate to the Block Editor
  2. Add an Image Block and upload an image
  3. Click the gear for block settings
  4. Tap Image Size row and verify value cycles through available sizes (Thumbnail, Medium, Large, Fullscreen).
  5. Verify the Image size changes as you click through the menu.
  6. Verify the Image Size is preserved if you update the post, leave, and return.

PR submission checklist:

  • I have considered adding unit tests where possible.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 6, 2019

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 19333. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 6, 2019

Warnings
⚠️ PR is missing at least one label.
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@cameronvoell cameronvoell deleted the try/gutenberg-image-size-setting-press-cycle branch February 14, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image Block Size Options - UX Production Ready
1 participant