Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/219 code highlight color #244

Merged
merged 3 commits into from
Feb 13, 2017
Merged

Issue/219 code highlight color #244

merged 3 commits into from
Feb 13, 2017

Conversation

theck13
Copy link
Contributor

@theck13 theck13 commented Feb 10, 2017 •
edited
Loading

Fix

The highlight color in code styled text is shown as described in #219 by modifying the new codeBackgroundAlpha attribute. The demonstration app uses 75% opacity.

Test

  1. Open demonstration app.
  2. Long-press on code block example text.
  3. Notice text is highlighted.
  4. Add aztec:codeBackgroundAlpha to AztecText with custom percentage.
  5. Notice code block background alpha.
  6. Long-press on code block example text.
  7. Notice text is highlighted.

@khaykov khaykov self-assigned this Feb 13, 2017
khaykov
khaykov approved these changes Feb 13, 2017
View reviewed changes
Copy link
Member

@khaykov khaykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@khaykov khaykov merged commit 5fe04ff into develop Feb 13, 2017
@khaykov khaykov deleted the issue/219-code-highlight-color branch February 13, 2017 01:56
@khaykov khaykov mentioned this pull request Feb 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaykov khaykov khaykov approved these changes

Assignees

@khaykov khaykov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theck13 @khaykov