[Build] Enable Non-Transitive Resources #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in this commit was automatically applied on triggering the "Refactor" -> "Migration to Non-Transitive R Classes..." migration process via AS.
oguzkocer
approved these changes
Jul 5, 2023
|
Thank you for reviewing and testing this @oguzkocer , you rock! 🙇 ❤️ 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a prerequisite for the
Gradle 8.1.1 & AGP 8.0.2 Upgrade for WPAndroid, WCAndroid & Related Libsproject.Platform Request:
pdnsEh-13V-p2Project Thread:
paaHJt-57Z-p2This PR enables non-transitive resources (
android.nonTransitiveRClass) for the project.FYI: This behavior becomes the default in AGP
8.0and higher. As such, this becomes a prerequisite for the AGP8.0.2upgrade, that is of course, unlessandroid.nonTransitiveRClassis explicitly set tofalse.Dependency Versions Refactor List:
To test:
Review
@oguzkocer
Make sure strings will be translated:
strings.xmlas a part of the integration PR.