Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a8c-ci-toolkit Buildkite plugin to new name and latest version #1039

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

rynaardb
Copy link
Contributor

What

  • Update the bash-cache Buildkite plugin name to a8c-ci-toolkit
  • Update the a8c-ci-toolkit plugin to version 2.14.0

Testing

Ensure that CI is green and that all checks passed.

Make sure strings will be translated:

  • If there are new strings that have to be translated, I have added them to the client's strings.xml as a part of the integration PR. N/A

@rynaardb rynaardb requested a review from oguzkocer March 22, 2023 15:55
@rynaardb
Copy link
Contributor Author

Thanks for the review and ✅ @oguzkocer! It seems like I don't have permission to merge my own PR 🤣 . Would you mind merging it on my behalf please?

@oguzkocer
Copy link
Contributor

Not at all! Although you should have the permission to do that. Let me look into it. 👀

@oguzkocer
Copy link
Contributor

@rynaardb I've updated the access for this repository which should give you permission to merge the PR. I also invited you to the Automattic team, which should give you access to other similar repos. Would you like to give it another try to merge the PR?

P.S: I'll internally record these changes once you confirm that it works :)

@rynaardb rynaardb merged commit 3684b8e into trunk Mar 22, 2023
@rynaardb rynaardb deleted the tooling/update-ci-toolkit-buildkite-plugin branch March 22, 2023 18:33
@rynaardb
Copy link
Contributor Author

@rynaardb I've updated the access for this repository which should give you permission to merge the PR. I also invited you to the Automattic team, which should give you access to other similar repos. Would you like to give it another try to merge the PR?

P.S: I'll internally record these changes once you confirm that it works :)

Ahh there we go, thanks a lot! I can confirm that I now have access, and I was able to merge this PR.

@oguzkocer
Copy link
Contributor

Happy to help and glad it's sorted out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants