Fix issue when adding an image on a blank line after a paragraph #1022
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
The issue fixed here is:
addMediaAfterBlocks
on the visual editor<p>Line 1</p><p>Line 2</p><p>Line 3</p>
The reason for this was that when the cursor is in a paragraph block, it's trying to add the image at the next line break. However, if it's on a line break, it should use that instead of looking for the next one after the current cursor position.
Test (or test it with the linked PR)
addMediaAfterBlocks
on the visual editor<p>Line 1</p><p>Line 2</p><p>Line 3</p>
Review
@khaykov
Make sure strings will be translated:
strings.xml
as a part of the integration PR.