Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic on logger #2745

Merged
merged 3 commits into from
Nov 5, 2023
Merged

Fix panic on logger #2745

merged 3 commits into from
Nov 5, 2023

Conversation

qwerty287
Copy link
Contributor

should close #2743

@qwerty287 qwerty287 added bug Something isn't working regression fix a bug that was not released yet labels Nov 5, 2023
@qwerty287 qwerty287 added this to the 2.0.0 milestone Nov 5, 2023
@qwerty287 qwerty287 requested a review from a team November 5, 2023 09:12
Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a0f2ee9) 34.01% compared to head (335fab5) 34.02%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2745      +/-   ##
==========================================
+ Coverage   34.01%   34.02%   +0.01%     
==========================================
  Files         214      214              
  Lines       13734    13735       +1     
==========================================
+ Hits         4672     4674       +2     
+ Misses       8695     8694       -1     
  Partials      367      367              
Files Coverage Δ
server/logging/log.go 66.21% <0.00%> (-0.91%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qwerty287 qwerty287 merged commit 45a5a2d into woodpecker-ci:main Nov 5, 2023
@qwerty287 qwerty287 deleted the fix-panic branch November 5, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression fix a bug that was not released yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runtime panic with latest next version
2 participants