Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support plugin-only secrets #1344

Merged
merged 5 commits into from
Oct 27, 2022
Merged

Conversation

qwerty287
Copy link
Contributor

@qwerty287 qwerty287 commented Oct 26, 2022

Closes #1071

@qwerty287 qwerty287 added the enhancement improve existing features label Oct 26, 2022
@qwerty287 qwerty287 added this to the 1.0.0 milestone Oct 26, 2022
@woodpecker-bot
Copy link
Contributor

woodpecker-bot commented Oct 26, 2022

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-1344.surge.sh

@qwerty287 qwerty287 marked this pull request as ready for review October 26, 2022 18:51
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Base: 44.71% // Head: 44.70% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (ca34d64) compared to base (da7d13a).
Patch coverage: 20.00% of modified lines in pull request are covered.

❗ Current head ca34d64 differs from pull request most recent head 35fd7cd. Consider uploading reports for the commit 35fd7cd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1344      +/-   ##
==========================================
- Coverage   44.71%   44.70%   -0.01%     
==========================================
  Files         137      137              
  Lines        9873     9884      +11     
==========================================
+ Hits         4415     4419       +4     
- Misses       5196     5203       +7     
  Partials      262      262              
Impacted Files Coverage Δ
pipeline/frontend/yaml/compiler/convert.go 0.00% <0.00%> (ø)
server/model/secret.go 48.07% <0.00%> (-0.95%) ⬇️
server/shared/procBuilder.go 81.52% <0.00%> (-0.30%) ⬇️
server/cron/cron.go 36.70% <33.33%> (ø)
pipeline/frontend/yaml/compiler/compiler.go 6.93% <100.00%> (+1.08%) ⬆️
pipeline/frontend/yaml/container.go 82.35% <100.00%> (+1.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@6543

This comment was marked as off-topic.

@6543
Copy link
Member

6543 commented Oct 27, 2022

the redundant translation entrys is unrelated to this but need to be solved ... in an other pull

@6543 6543 enabled auto-merge (squash) October 27, 2022 01:53
@6543 6543 merged commit e568c42 into woodpecker-ci:master Oct 27, 2022
@6543
Copy link
Member

6543 commented Oct 27, 2022

@qwerty287 please submit a ref to the issue to OpenCollective for 50usd

@qwerty287
Copy link
Contributor Author

How do I do that? Just use the contact form?

@qwerty287 qwerty287 deleted the secret-plugin branch October 27, 2022 11:36
@6543
Copy link
Member

6543 commented Oct 27, 2022

@6543
Copy link
Member

6543 commented Oct 27, 2022

you just need to create an account and use that in "who is paied" ...

@6543
Copy link
Member

6543 commented Oct 27, 2022

... only the admins (anbraten & me) + OpenSourceCollective will see that info

@qwerty287
Copy link
Contributor Author

I'm not a member of the collective and thus can't access the page.

@6543
Copy link
Member

6543 commented Oct 27, 2022

@qwerty287 DM -> discord (in general we need a way to pay people who did a bounty less complicated!)

simmstein pushed a commit to simmstein/woodpecker that referenced this pull request Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Important] Limit secret access to plugins only
5 participants