This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Move Combobox to components package
#11353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opr
added
status: needs review
type: enhancement
|
@nerrad pinging you because you mentioned that we should either avoid exporting anything that has a dependency on When we come to documenting these components we should make it clear that this is something we plan to do, so some minor changes may occur, though we should really try to make it a seamless a transition as possible. As for handling a replacement in future, if any props on the current component are not on the replacement, we can show a deprecation message in the console about that. If any new props are on the replacement, we will need to figure out what default values to give them to keep the component's behaviour the same as it is currently. The main concern is about the behaviour/UX of the combobox, i.e. whether auto completion works the same in the replacement, what do the arrow keys do (should be standard and follow accessibility guidelines at any rate) and also whether the format for options would be the same in the replacement (if not, we can handle the mapping) What do you think about this approach, is there anything else we should be careful of here besides what I mentioned? |
opr
force-pushed
the
update/move-combobox
branch
from
3e66612 to
9ea4d0c
Compare
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
packages/components/combobox/index.tsx
|
|
Size Change: +24.2 kB (+2%) Total Size: 1.55 MB
ℹ️ View Unchanged
|
opr
force-pushed
the
update/move-combobox
branch
from
9ea4d0c to
7a32f93
Compare
mikejolley
approved these changes
Oct 27, 2023
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
|
Thanks for the review Mike, I'm going to set this back to draft for now until we figure out the components issue. |
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
github-actions
bot
removed
the
status: stale
ralucaStan
added
the
focus: components
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Moves the
Comboboxcomponent to the components package and updates the places it is imported:CountryInputStateInputWhy
As more developers integrate their extensions with WooCommerce Blocks, the case for reusing components grows. This starts the ball rolling by creating a new package. Rather than recreating components developers can access
wc.blocksComponentsand get the ones we need.Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog