Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

add build:feature-config to readme instructions #1545

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

rrennick
Copy link
Contributor

@rrennick rrennick commented Feb 13, 2019

#1500 added npm build:feature-config to the build process. This PR adds that to the npm run build command.

Testing instructions

  1. Delete includes/feature-config.php if it exists.
  2. Run npm run build
  3. Load the dashboard of the site without error.

@rrennick rrennick added type: documentation This issue is a request for better documentation. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. labels Feb 13, 2019
Copy link
Collaborator

@justinshreve justinshreve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the missing step for npm run build and thanks for the fix! Should we instead update the command in package.json? so you can still just run npm run build and it will run both pieces?

@rrennick
Copy link
Contributor Author

Should we instead update the command in package.json? so you can still just run npm run build and it will run both pieces?

Sounds like a better fix.

@rrennick
Copy link
Contributor Author

@justinshreve Thanks. I updated the PR and testing instructions.

Copy link
Collaborator

@justinshreve justinshreve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and is building correctly, and no fatal around the missing file. Thanks again!

@rrennick rrennick merged commit 9a9c4d5 into master Feb 14, 2019
@rrennick rrennick deleted the doc/update-readme-build-instructions branch February 14, 2019 17:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool: monorepo infrastructure type: documentation This issue is a request for better documentation. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants