:query_params
option for aws_sigv4_url/1
#455
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for adding query params to presigned URLs. S3 allows response headers to be overridden using query params such as
response-cache-control
,response-content-disposition
,response-content-encoding
, etc. See https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html for details.I've tested this implementation by making requests to S3 with
response-content-disposition
andresponse-cache-control
.If this gets merged then I'll submit a separate pull-request to add support for this to
ReqS3.presign_url/1
.Thanks!