Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:query_params option for aws_sigv4_url/1 #455

Closed
wants to merge 2 commits into from

Conversation

balexand
Copy link

This adds support for adding query params to presigned URLs. S3 allows response headers to be overridden using query params such as response-cache-control, response-content-disposition, response-content-encoding, etc. See https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html for details.

I've tested this implementation by making requests to S3 with response-content-disposition and response-cache-control.

If this gets merged then I'll submit a separate pull-request to add support for this to ReqS3.presign_url/1.

Thanks!

@balexand
Copy link
Author

This is a duplicate of #445

@balexand balexand closed this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant