Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #255 - adding new code tables 4.120, 4.121. 4.122 #304

Merged
merged 26 commits into from
Feb 13, 2025
Merged

issue #255 - adding new code tables 4.120, 4.121. 4.122 #304

merged 26 commits into from
Feb 13, 2025

Conversation

amilan17
Copy link
Member

@amilan17 amilan17 commented Jan 23, 2025 •
edited
Loading

@amilan17 amilan17 linked an issue Jan 23, 2025 that may be closed by this pull request
New section 4 templates and tables for verification scores #255
Closed
@amilan17 amilan17 marked this pull request as draft January 23, 2025 13:31
@amilan17 amilan17 changed the base branch from master to FT2025-1 January 23, 2025 13:31
@amilan17 amilan17 marked this pull request as ready for review January 28, 2025 14:39
@amilan17 amilan17 marked this pull request as draft January 29, 2025 14:59
amilan17
amilan17 commented Jan 29, 2025
View reviewed changes
Copy link
Member Author

@amilan17 amilan17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebvi please look at the suggested text for the octets for template 4.146.

@amilan17 amilan17 changed the title issue #255 - adding new code tables 4.120, 34.121. 4.122 issue #255 - adding new code tables 4.120, 4.121. 4.122 Feb 6, 2025
amilan17
amilan17 commented Feb 6, 2025
View reviewed changes
Copy link
Member Author

@amilan17 amilan17 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebvi please see specific questions below, mostly for the rows that are "notes"

amilan17
amilan17 commented Feb 7, 2025
View reviewed changes
Copy link
Member Author

@amilan17 amilan17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebvi see suggestions

@amilan17 amilan17 marked this pull request as ready for review February 13, 2025 14:29
@amilan17 amilan17 merged commit 58e91b9 into FT2025-1 Feb 13, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New section 4 templates and tables for verification scores
3 participants
@amilan17 @sebvi @SibylleK