Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failures #74

Merged
merged 2 commits into from
May 18, 2024
Merged

Fix CI failures #74

merged 2 commits into from
May 18, 2024

Conversation

strouptl
Copy link
Collaborator

Try pinning sqlite3 to "~> 1.4" for CI tests (needed for ActiveRecord adapter for now).

cf. rails/rails#51592

@strouptl strouptl changed the title Pin sqlite3 to "~> 1.4" for CI tests Fix CI failures May 18, 2024
@strouptl
Copy link
Collaborator Author

@strzibny, I think something must changed with the underlying Github CI images since the CI tests were run on the 0.6.0 release. The CI tests are passing again, with these changes though.

If you don't mind, lets merge this branch first, and then I will rebase the confirm_otp_token branch once more.

Just to double check, are you OK with dropping support for Ruby 2.7 and 3.0 (both EOL as of 4/23/2024).

References: https://www.ruby-lang.org/en/downloads/branches/

@strzibny strzibny merged commit 31fae1f into wmlele:master May 18, 2024
1 check passed
@strzibny
Copy link
Collaborator

Yes, I am, thx

@strouptl strouptl deleted the fix_sqlite3_version branch May 18, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants