Add MIT license type to gemspec; #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@strzibny, it looks like our tests for Rails 7.0 are failing due to a compatibility issue between Rails 7.0, and the latest version of concurrent-ruby (1.3.5), which was released on February 5th. The issue is resolved in Rails 7.1, but it does not look like it is being addressed in Rails 7.0. Is it OK if we drop support for Rails 7.0 to resolve these issues? We are a little early, but support for Rails 7.0 ends anyway on April 1st, 2025. References:
|
strouptl
force-pushed
the
add_mit_licence
branch
from
78e4e5d to
d25a677
Compare
|
Yes |
|
Great! I have created a PR for it here: #105. |
strzibny
reviewed
Mar 8, 2025
| @@ -10,6 +10,7 @@ Gem::Specification.new do |gem| | |||
| gem.description = "OTP authentication for Devise" | |||
| gem.summary = "Time Based OTP/rfc6238 compatible authentication for Devise" | |||
| gem.homepage = "https://github.com/wmlele/devise-otp" | |||
| gem.license = 'MIT' | |||
There was a problem hiding this comment.
It's a small thing, but let's keep strings with " (double quote) so it's all same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "MIT" license type to gemspec (resolves #101).