-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the capability to change the language between tests #873
Merged
Merged
Changes from 10 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
797a3dd
pipe language through to xcrun launch
bdff879
Revert "pipe language through to xcrun launch"
d5dae80
pipe the thing through for real this time
30afc5f
pass the other arg
d7e8292
Merge branch 'master' into locale
4dd1215
remove console.logs
9e00b94
pass language prop to android
9fb206f
remove a newline
92e7a42
fix unit tests
b160757
add a unit test
1529795
Merge branch 'master' into locale
697e6bb
re-apply changes and fix unit tests
19f73da
add a locale option
12a7a60
update unit test
8b6f74f
100% test coverage
9de21e5
temp rename unneeded test files
c11308d
temp use iphone 6
9ee6c55
install and link react-native-device-info
fe31f84
add boilerplate for a language screen
9cfd763
render current country and locale in test app
1de2f1e
add e2e test
8c648b5
add language UI to language screen
ab62a22
update e2e
55e256d
Revert "install and link react-native-device-info"
667475c
e2e test is passing
3f6bb30
clean up language screen
971fb09
temp switch emulator
6b1b446
add language support to test app for android
50b4d3e
Revert "add language support to test app for android"
d5d4955
add android support to language screen
df7967f
update android API
3768a34
Revert "temp switch emulator"
85a2ccd
Revert "temp use iphone 6"
168e42e
Revert "temp rename unneeded test files"
4691118
uncomment some tests
f7f8e2f
comment out the not cross-plat test
28c87f0
Merge branch 'master' into locale-sync-2
7c7596d
update docs
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a locale option as well.