Set VC's title independent from possible tab bar button label #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
setTitle
set the view controller title throughnavigationItem
to prevent interference with a possible tab bar label.Fixes https://github.com/wix/react-native-navigation/issues/113.
Using
.navigationItem.title
overrides thetitle
property of a view controller (which is automatically set by the tab bar controller to be the tab button title) when displaying it in the nav bar. See "The Middle Item" here: https://developer.apple.com/library/ios/documentation/UIKit/Reference/UINavigationController_ClassAs far as I can tell, no other actions that change the title (push/reset/etc) should need this, as they either don't apply to a tab bar controller's root element, or they replace it with a new VC entirely.