Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set VC's title independent from possible tab bar button label #74

Closed
wants to merge 1 commit into from

Conversation

dingbat
Copy link

@dingbat dingbat commented Jul 18, 2016

Makes setTitle set the view controller title through navigationItem to prevent interference with a possible tab bar label.

Fixes https://github.com/wix/react-native-navigation/issues/113.

Using .navigationItem.title overrides the title property of a view controller (which is automatically set by the tab bar controller to be the tab button title) when displaying it in the nav bar. See "The Middle Item" here: https://developer.apple.com/library/ios/documentation/UIKit/Reference/UINavigationController_Class

As far as I can tell, no other actions that change the title (push/reset/etc) should need this, as they either don't apply to a tab bar controller's root element, or they replace it with a new VC entirely.

@drorbiran
Copy link
Contributor

Hi, we wanted to update you that we are currently postponing the processing of pull requests.
Please refer to React native controllers evolution, we'll appreciate your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants