fix: exclude tailwind package when installing integration #13106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 571f2d7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
florian-lefebvre
approved these changes
Jan 31, 2025
CodSpeed Performance ReportMerging #13106 will not alter performanceComparing Summary
|
ematipico
approved these changes
Jan 31, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Special-cases tailwind to ensure it doesn't install the integration package, which is deprecated. Previously it was always installing the integration package, even though it was also always added to the dependencies list. This changes it to only install the listed deps. It also adds an
integrationNamefield, because in logs it was confusing having it log@astrojs/tailwindwhen that package wasn't actually installed.Fixes #13097
Testing
There are currently no tests for
atro add. It's a tough one to test without some kind of mocking for the package manager, so I'll leave it for now, beacuse this bug is affecting lots of users.Docs