ENG-1501 - Monorepo required changes #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daanpersoons
force-pushed
the
monorepo-required-changes
branch
2 times, most recently
from
9324801 to
50fbd61
Compare
djbe
requested changes
Sep 18, 2024
| @@ -23,12 +23,21 @@ inputs: | |||
| image: | |||
| description: Image name (fallback to repository name) | |||
| required: false | |||
| image-suffix: | |||
There was a problem hiding this comment.
As I mentioned in the other action, this action doesn't need to know about image suffixes, that's for the workflows themselves.
action.yml
Outdated
| target: | ||
| description: Variant (build-stage) you want to build. | ||
| required: false | ||
| build-argument: |
There was a problem hiding this comment.
Asked this in the workflows repo: why add a build argument? We already have atarget, so we can use that to differentiate variants.
djbe
force-pushed
the
monorepo-required-changes
branch
from
50fbd61 to
8ea9920
Compare
|
I've added the target parameter in |
|
No longer needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.