feat/expo rn module #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MAN THAT WAS HARD!
had to
- downgrade react-native to 0.71
- upgrade kotlin to 1.8
- downgrade gradle to 7.6
- change the location of @react-native/gradle-plugin to
react-native-gradle-plugin
- setup the expo config to use the hermes compiler (not mention in doc
:/ )
facebook/react-native#38179
expo/expo#22008
ran into this ugly one called java.lang.IllegalStateException: Current Activity is of incorrect class, expected AppCompatActivity, received ui.MyReactActivity hard to debug for real for real. ended up looking into expo docs that said they are getting rid of the bare instructions and then expo/expo#18022 then that had me be like where is that erorr even from... which lead me to git blame packages/expo-modules-core/android/src/main/java/expo/modules/kotlin/AppContext.kt which lead me to expo/expo#19573 which lead me to s/Activity/AppCompatActivity/g in android/app/src/main/java/com/github/quarck/calnotify/ui/MyReactActivity.kt
hope we don't need expo install modules either
in modules/my-module/android/src/main/java/expo/modules/mymodule/MyModule.kt Constants, Events, and AsyncFunction work beautifully! View seems to work but I don't really understand it weirdly Function DOES NOT WORK AT ALL!!! it just says is not a function and since it seemed like the easiest thing and was what I looked at first it made me thing everything else was broken too :/ lost A LOT of time to that
to save myself time in the future
unfortunately debugging syncronous native modules in it does not :/
This was referenced Oct 14, 2023
…shit expo-module-scripts 3.1.0 depends on @expo/config 7.5 which breaks shit
williscool
force-pushed
the
feat/expo_rn_module
branch
from
bb60686 to
5554099
Compare
turns out it breaks build. like flipper but not worth build break This reverts commit 8612ff3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bottom Line: Expo React native modules WORK!
The tutorial that finally got things going
https://docs.expo.dev/modules/get-started/#adding-a-new-module-to-an-existing-application
simple demo app
modules/my-module/android/src/main/java/expo/modules/mymodule/MyModule.kt
WARNING: we will need to HEAVILY FAVOR asynchronous functions for anything BECAUSE WE CANNOT DEBUG SYNC ONES.
enables:
figured out an documented
also:
Fixes #3