Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite deps in BFS order #50

Open
Stebalien opened this issue Aug 28, 2018 · 2 comments
Open

Rewrite deps in BFS order #50

Stebalien opened this issue Aug 28, 2018 · 2 comments
Assignees
@schomatis
Labels
bug

Comments

@Stebalien
Copy link
Collaborator

#47 fixed the direct issue in #44 but didn't fix the recursive case. In general, we should probably be rewriting BFS order (and never overwriting). That is, process a packages direct dependencies first before falling back on transitive dependencies, recursively.
@Stebalien Stebalien added the bug label Aug 28, 2018
@schomatis schomatis self-assigned this Sep 18, 2018
@schomatis
Copy link
Collaborator

Agreed, I'll take this one, it seems like an excellent test case to see if I could apply the DAG walker here.

@schomatis
Copy link
Collaborator

Oh, unless this losses relevance with the lockfile support in #49.

@schomatis schomatis mentioned this issue Nov 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schomatis schomatis

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stebalien @schomatis