Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure after gx-go link go-libp2p #482

Closed
cannium opened this issue Nov 12, 2018 · 7 comments
Closed

Build failure after gx-go link go-libp2p #482

cannium opened this issue Nov 12, 2018 · 7 comments

Comments

@cannium
Copy link
Contributor

cannium commented Nov 12, 2018

Current ipfs master version could not be built after gx-go link go-libp2p, something inconsistent

# gx/ipfs/QmXRphxBT4BH2GqGHUSbqULm7wNsxnpA2NrbNaY3DU1Y5K/go-bitswap/testnet
../../../../../gx/ipfs/QmXRphxBT4BH2GqGHUSbqULm7wNsxnpA2NrbNaY3DU1Y5K/go-bitswap/testnet/peernet.go:30:30: cannot use client (type "gx/ipfs/QmahxMNoNuSsgQefo9rkpcfRFmQrMN6Q99aztKXf63K7YJ/go-libp2p-host".Host) as type "gx/ipfs/QmVrjR2KMe57y4YyfHdYa3yKD278gN8W7CTiqSuYmxjA7F/go-libp2p-host".Host in argument to network.NewFromIpfsHost:
	"gx/ipfs/QmahxMNoNuSsgQefo9rkpcfRFmQrMN6Q99aztKXf63K7YJ/go-libp2p-host".Host does not implement "gx/ipfs/QmVrjR2KMe57y4YyfHdYa3yKD278gN8W7CTiqSuYmxjA7F/go-libp2p-host".Host (wrong type for ConnManager method)
		have ConnManager() "gx/ipfs/QmQSucBpqUVQ5Q1stDmm2Bon4Tq4KNhNXuVmLMraARoUoh/go-libp2p-interface-connmgr".ConnManager
		want ConnManager() "gx/ipfs/QmR8DgkC3Xnc1TnfH1DvZtLRzPKJBrWfeDKseeXnUY6CN5/go-libp2p-interface-connmgr".ConnManager

I think you might have some internal tools to handle it. Please fix.

@cannium cannium changed the title Build failure after gx-go link libp2p Build failure after gx-go link go-libp2p Nov 12, 2018
@Stebalien
Copy link
Member

@cannium if you install the latest gx-go, you can run gx-go link -o go-libp2p. This will override libp2p's deps with the one's specified by go-ipfs.

This should have been the default. Unfortunately, "linked" deps are global. That means that calling gx-go link -o go-libp2p from go-ipfs will also other local packages using go-libp2p to use go-ipfs's dep versions.

I'm guessing the fix is ipfs/kubo#5762. However, I'd like to delay merging that for a bit as it'll make merging some other changes painful.

@schomatis
Copy link

Yes, I tried that when I saw this issue but it caused even more errors (maybe because of whyrusleeping/gx-go#50), using the PR you're mentioning indeed fixes the problem.

@cannium
Copy link
Contributor Author

cannium commented Nov 13, 2018

Thank you both for timely response.

@hannahhoward
Copy link
Contributor

hannahhoward commented Nov 13, 2018

Yea sorry folks this is my doing -- had to publish new versions up the chain for a small package update (go-ipfs-delay) but the final set up updates is not merged into go-ipfs master -- and is in the PR referenced above.

apologies for the synchronization challenges.

@saresend
Copy link

Hey! Sorry to jump on this issue, but I'm running into similar problems with go-libp2p where the dependencies aren't lining up with what libp2p is expecting. I'm very new to how gx handles dependencies and I was wondering what specifically the workaround here is? Thanks!

@cannium
Copy link
Contributor Author

cannium commented Nov 14, 2018

@saresend checkout branch gx/update-kque0y of go-ipfs

@Stebalien
Copy link
Member

This has been merged and fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants