Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note on ReadableStreamDefaultControllerEnqueue is inaccurate #824

Closed
ricea opened this issue Oct 4, 2017 · 0 comments · Fixed by #829
Closed

Note on ReadableStreamDefaultControllerEnqueue is inaccurate #824

ricea opened this issue Oct 4, 2017 · 0 comments · Fixed by #829

Comments

@ricea
Copy link
Collaborator

ricea commented Oct 4, 2017

https://streams.spec.whatwg.org/commit-snapshots/cd10872861aa35c0490f5d4ff46db7593e866a87#readable-stream-default-controller-enqueue

In this case we allow the controller’s enqueue method to be called and silently do nothing

This hasn't been true since e601d69 in Dec 2015. The change was documented in the change description, and discussed in #424, so it was clearly intentional. The note was just never removed.

I prefer the new behaviour for enqueue() since I think it might be harmful to continue to run code on the assumption that the chunk has been queued. Plus this behaviour has shipped in browsers so changing it now could break running code. I propose removing the note.
ricea added a commit to ricea/streams that referenced this issue Oct 6, 2017
@ricea
Remove inaccurate note about ReadableStreamDefaultControllerEnqueue
bf4b316 
ReadableStreamDefaultControllerEnqueue has a note indicating that it
could be called when the stream was closed without an exception being
thrown. This hasn't been true since December 2015. Remove the inaccurate
note.

Fixes whatwg#824.
@ricea ricea mentioned this issue Oct 6, 2017
Merged
domenic pushed a commit that referenced this issue Oct 11, 2017
@ricea @domenic
Fix note about tricky [[closeRequested]] vs. [[state]] situation
0fbbca4 
ReadableStreamDefaultControllerEnqueue has a note indicating that it could be called when the stream was closed without an exception being thrown. This hasn't been true since e601d69. Additionally, the remaining part of that note refers to steps that were moved in ad0dfef. Move that remaining part to the correct location, and update it to be more comprehensive.

Fixes #824.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove inaccurate note about ReadableStreamDefaultControllerEnqueue ricea/streams
1 participant
@ricea