Clarify what should happen for selectionStart = null #1640
Conversation
|
From the new text I can't understand why selectionStart/selectionEnd are nullable at all. If we just made them non-nullable, null would be converted to 0, which I think is correct, right? And from the getter description they never return null, right? |
|
They return null (instead of throwing) when the API "doesn't apply". See the paragraphs at the top of the section and #1006. |
|
cc @smaug---- |
|
I see. I guess that feels pretty non-local, but I don't have any great suggestions, besides maybe adding "when it applies" to almost every paragraph in that section. LGTM, maybe we should wait for @smaug----. |
|
yeah, it is very non-local, and I've forgotten that couple of times and wonder what is happening there. |
|
We can inline the "don't apply" checks for each API, but that should be a separate PR in my opinion. |
Fixes #1628.