Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a send smtp test email button in admin panel #1359

Merged
merged 3 commits into from
Nov 29, 2017

Conversation

nztqa
Copy link
Contributor

@nztqa nztqa commented Nov 27, 2017

Add a send smtp test email button in admin panel

image


This change is Reviewable

@ocdtrekkie
Copy link
Contributor

Given how many SMTP related issue filings I've seen, and the fact that every other tool I've used that includes SMTP config includes a button to test it, I am 100% in favor of this PR.

@xet7
Copy link
Member

xet7 commented Nov 27, 2017

@nztqa

Is it possible to change error to be shown directly on admin panel ?

@nztqa
Copy link
Contributor Author

nztqa commented Nov 27, 2017

@xet7

use a shorthand method. alert

--- a/client/components/settings/settingBody.js
+++ b/client/components/settings/settingBody.js
@@ -129,8 +129,10 @@ BlazeComponent.extendComponent({
     Meteor.call('sendSMTPTestEmail', (err, ret) => {
       if (!err && ret) { /* eslint-disable no-console */
         console.log('Success:', ret.message, ret.email);
+        alert('Success');
       } else {
         console.log('Error: Sending test email', err);
+        alert(err);
       }  /* eslint-enable no-console */
     });
   },

image

@xet7
Copy link
Member

xet7 commented Nov 27, 2017

@nztqa

Please add that alert code to this pull request.

@xet7
Copy link
Member

xet7 commented Nov 27, 2017

@nztqa

Please make all user visible text, like Success, errors, email text, etc translateable, and add those changes to this pull request.

@nztqa
Copy link
Contributor Author

nztqa commented Nov 28, 2017

Finished

@xet7 xet7 merged commit 44559b5 into wekan:devel Nov 29, 2017
@nztqa nztqa deleted the improve-smtp-testing branch November 30, 2017 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants