fix: set proper default value in radix with content block #4937
+297
−216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User reported in discord. Radix components like accordion does not open first item by default when use with content block. The reason was in our default detection. We used indexes within ancestor and when put item inside of content block template it gets 0 but not rendered. Here improved the logic to reset index when render inside of block template.
kof
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User reported in discord.
Radix components like accordion does not open first item by default when use with content block. The reason was in our default detection.
We used indexes within ancestor and when put item inside of content block template it gets 0 but not rendered.
Here improved the logic to reset index when render inside of block template.