Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes 2 bugs in advanced panel #4935

Merged
merged 2 commits into from
Mar 1, 2025
Merged

fix: Fixes 2 bugs in advanced panel #4935

merged 2 commits into from
Mar 1, 2025

Conversation

kof
Copy link
Member

@kof kof commented Feb 28, 2025

Description

Use case 1

  1. add a property
  2. copy all
  3. paste into any text editor
  4. see that recent one is not copied

Use case 2

  1. add 2 properties
  2. use backspace to reset the second property
  3. focus should be on the first value after deleting the second one
  4. use backspace to delete the first property
  5. see focus jumped to search

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof changed the title fix: fixes 2 bugs in advanced panel fix: Fixes 2 bugs in advanced panel Feb 28, 2025
@kof kof requested a review from johnsicili February 28, 2025 17:24
@kof kof merged commit 11c6521 into main Mar 1, 2025
19 checks passed
@kof kof deleted the advanced-bugs2 branch March 1, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants