Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Additional way to reset in spacing #4924

Merged
merged 2 commits into from
Mar 2, 2025
Merged

feat: Additional way to reset in spacing #4924

merged 2 commits into from
Mar 2, 2025

Conversation

kof
Copy link
Member

@kof kof commented Feb 27, 2025

Description

closes #4844

As a user when I don't know about option+click shorthand, and try to reset spacing, only other way is to wait for the tooltip to come. If you click, like you do on other labels - input will come but no way to reset.

Solution: show a label next to the input.

Steps for reproduction

  1. click on any spacing value
  2. see label next to input
  3. test usual label functionality

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested review from TrySound and johnsicili February 27, 2025 14:22
Copy link
Member

@TrySound TrySound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@kof kof merged commit 75b82d6 into main Mar 2, 2025
17 checks passed
@kof kof deleted the spacing-label branch March 2, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional way to reset in spacing
3 participants